[CI] Added Serial Execution Engine Test #3069
Open
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
There was a problem hiding this comment.
Thanks for the PR @AlexandreSinger. Agreed with having this test since we were basically leaving parts of the code base completely untested. I had one tiny nitpick about the name of the test, LGTM other than that.
vpr/src/route/route_utils.cpp
Outdated
Comment on lines
22
to
25
|
|
||
| #ifdef VPR_USE_TBB | ||
| #include "stats.h" | ||
| #endif // VPR_USE_TBB |
There was a problem hiding this comment.
Not a comment, just a question: Since get_num_bends_and_length was used even if VPR_USE_TBB was 0, does VPR just fail to compile without TBB right now or is it included in another header?
There was a problem hiding this comment.
It did. Thats what notified me that this was untested.
I actually hotfixed this issue in a separate PR: #3067
This PR still needs to be rebased.
Since the CI always installs oneTBB and the execution engine is set to auto, I found that the CI always tested with the tbb execution engine. Some users may not have oneTBB installed for one reason or another and we need to ensure that VTR always builds. Added a CI test which sets the parallel execution engine to serial for Tatum and VPR.
AlexandreSinger
force-pushed
the
feature-ci-test-serial-engine
branch
from
9888bf9 to
f2290ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the CI always installs oneTBB and the execution engine is set to auto, I found that the CI always tested with the tbb execution engine. Some users may not have oneTBB installed for one reason or another and we need to ensure that VTR always builds.
Added a CI test which sets the parallel execution engine to serial for Tatum and VPR.